diff options
| author |   Vladimir Oltean <vladimir.oltean@nxp.com> | 2021-08-10 16:13:54 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-08-11 14:44:58 +0100 |
| commit | 6bef794da6d3bd347c18e93ad33483bd8903d9fd (patch) | |
| tree | 1ce71a803cc78ef91d743a51ced9be8606b429aa /net/dsa/tag_qca.c | |
| parent | net: dsa: create a helper that strips EtherType DSA headers on RX (diff) | |
| download | linux-dev-6bef794da6d3bd347c18e93ad33483bd8903d9fd.tar.xz linux-dev-6bef794da6d3bd347c18e93ad33483bd8903d9fd.zip | |
net: dsa: create a helper which allocates space for EtherType DSA headers
Hide away the memmove used by DSA EtherType header taggers to shift the
MAC SA and DA to the left to make room for the header, after they've
called skb_push(). The call to skb_push() is still left explicit in
drivers, to be symmetric with dsa_strip_etype_header, and because not
all callers can be refactored to do it (for example, brcm_tag_xmit_ll
has common code for a pre-Ethernet DSA tag and an EtherType DSA tag).
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa/tag_qca.c')
| -rw-r--r-- | net/dsa/tag_qca.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c index f9fc881da591..c68a814188e7 100644 --- a/net/dsa/tag_qca.c +++ b/net/dsa/tag_qca.c @@ -36,7 +36,7 @@ static struct sk_buff *qca_tag_xmit(struct sk_buff *skb, struct net_device *dev) skb_push(skb, QCA_HDR_LEN); - memmove(skb->data, skb->data + QCA_HDR_LEN, 2 * ETH_ALEN); + dsa_alloc_etype_header(skb, QCA_HDR_LEN); phdr = (__be16 *)(skb->data + 2 * ETH_ALEN); /* Set the version field, and set destination port information */ |