diff options
| author |   Eric Dumazet <edumazet@google.com> | 2014-09-30 22:12:05 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-10-01 13:44:05 -0400 |
| commit | 2c804d0f8fc7799981d9fdd8c88653541b28c1a7 (patch) | |
| tree | 595446444860fdf7c4e1fe200b218280b10f117c /net/ipv4/af_inet.c | |
| parent | fm10k: using vmalloc requires including linux/vmalloc.h (diff) | |
| download | linux-dev-2c804d0f8fc7799981d9fdd8c88653541b28c1a7.tar.xz linux-dev-2c804d0f8fc7799981d9fdd8c88653541b28c1a7.zip | |
ipv4: mentions skb_gro_postpull_rcsum() in inet_gro_receive()
Proper CHECKSUM_COMPLETE support needs to adjust skb->csum
when we remove one header. Its done using skb_gro_postpull_rcsum()
In the case of IPv4, we know that the adjustment is not really needed,
because the checksum over IPv4 header is 0. Lets add a comment to
ease code comprehension and avoid copy/paste errors.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/af_inet.c')
| -rw-r--r-- | net/ipv4/af_inet.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 28e589c5f32d..92db7a69f2b9 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -1369,6 +1369,9 @@ static struct sk_buff **inet_gro_receive(struct sk_buff **head, * immediately following this IP hdr. */ + /* Note : No need to call skb_gro_postpull_rcsum() here, + * as we already checked checksum over ipv4 header was 0 + */ skb_gro_pull(skb, sizeof(*iph)); skb_set_transport_header(skb, skb_gro_offset(skb)); |