diff options
| author |   Jim Westfall <jwestfall@surrealistic.net> | 2018-01-14 04:18:51 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-01-15 14:53:43 -0500 |
| commit | cd9ff4de0107c65d69d02253bb25d6db93c3dbc1 (patch) | |
| tree | 84e0e11399bdb5eb0f479497026f16d5a7259a8f /net/ipv4/arp.c | |
| parent | net: Allow neigh contructor functions ability to modify the primary_key (diff) | |
| download | linux-dev-cd9ff4de0107c65d69d02253bb25d6db93c3dbc1.tar.xz linux-dev-cd9ff4de0107c65d69d02253bb25d6db93c3dbc1.zip | |
ipv4: Make neigh lookup keys for loopback/point-to-point devices be INADDR_ANY
Map all lookup neigh keys to INADDR_ANY for loopback/point-to-point devices
to avoid making an entry for every remote ip the device needs to talk to.
This used the be the old behavior but became broken in a263b3093641f
(ipv4: Make neigh lookups directly in output packet path) and later removed
in 0bb4087cbec0 (ipv4: Fix neigh lookup keying over loopback/point-to-point
devices) because it was broken.
Signed-off-by: Jim Westfall <jwestfall@surrealistic.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/arp.c')
| -rw-r--r-- | net/ipv4/arp.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index a8d7c5a9fb05..6c231b43974d 100644 --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c @@ -223,11 +223,16 @@ static bool arp_key_eq(const struct neighbour *neigh, const void *pkey) static int arp_constructor(struct neighbour *neigh) { - __be32 addr = *(__be32 *)neigh->primary_key; + __be32 addr; struct net_device *dev = neigh->dev; struct in_device *in_dev; struct neigh_parms *parms; + u32 inaddr_any = INADDR_ANY; + if (dev->flags & (IFF_LOOPBACK | IFF_POINTOPOINT)) + memcpy(neigh->primary_key, &inaddr_any, arp_tbl.key_len); + + addr = *(__be32 *)neigh->primary_key; rcu_read_lock(); in_dev = __in_dev_get_rcu(dev); if (!in_dev) { |