diff options
| author |   David Ahern <dsahern@gmail.com> | 2018-07-07 16:15:26 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-07-08 10:54:58 +0900 |
| commit | e7372197e15856ec4ee66b668020a662994db103 (patch) | |
| tree | 848d1134aedf7b4a52efb58863675e90a8b4925a /net/ipv4/fib_frontend.c | |
| parent | Merge branch 'net-sched-fix-NULL-dereference-in-goto-chain-control-action' (diff) | |
| download | linux-dev-e7372197e15856ec4ee66b668020a662994db103.tar.xz linux-dev-e7372197e15856ec4ee66b668020a662994db103.zip | |
net/ipv4: Set oif in fib_compute_spec_dst
Xin reported that icmp replies may not use the address on the device the
echo request is received if the destination address is broadcast. Instead
a route lookup is done without considering VRF context. Fix by setting
oif in flow struct to the master device if it is enslaved. That directs
the lookup to the VRF table. If the device is not enslaved, oif is still
0 so no affect.
Fixes: cd2fbe1b6b51 ("net: Use VRF device index for lookups on RX")
Reported-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fib_frontend.c')
| -rw-r--r-- | net/ipv4/fib_frontend.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index b21833651394..e46cdd310e5f 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -300,6 +300,7 @@ __be32 fib_compute_spec_dst(struct sk_buff *skb) if (!ipv4_is_zeronet(ip_hdr(skb)->saddr)) { struct flowi4 fl4 = { .flowi4_iif = LOOPBACK_IFINDEX, + .flowi4_oif = l3mdev_master_ifindex_rcu(dev), .daddr = ip_hdr(skb)->saddr, .flowi4_tos = RT_TOS(ip_hdr(skb)->tos), .flowi4_scope = scope, |