diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-11 17:15:26 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-13 12:56:49 +0100 |
| commit | d2efabce81db7eed1c98fa1a3f203f0edd738ac3 (patch) | |
| tree | 2b2f896100de279d80a8129c944c9aa8d049510e /net/ipv4/icmp.c | |
| parent | icmp: Fix a data-race around sysctl_icmp_ignore_bogus_error_responses. (diff) | |
| download | linux-dev-d2efabce81db7eed1c98fa1a3f203f0edd738ac3.tar.xz linux-dev-d2efabce81db7eed1c98fa1a3f203f0edd738ac3.zip | |
icmp: Fix a data-race around sysctl_icmp_errors_use_inbound_ifaddr.
While reading sysctl_icmp_errors_use_inbound_ifaddr, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its reader.
Fixes: 1c2fb7f93cb2 ("[IPV4]: Sysctl configurable icmp error source address.")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/icmp.c')
| -rw-r--r-- | net/ipv4/icmp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 0c01696c5584..a49b68d6b969 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -693,7 +693,7 @@ void __icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info, rcu_read_lock(); if (rt_is_input_route(rt) && - net->ipv4.sysctl_icmp_errors_use_inbound_ifaddr) + READ_ONCE(net->ipv4.sysctl_icmp_errors_use_inbound_ifaddr)) dev = dev_get_by_index_rcu(net, inet_iif(skb_in)); if (dev) |