diff options
| author |   Niklas Cassel <niklas.cassel@axis.com> | 2018-01-22 16:59:50 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-01-24 16:28:07 -0500 |
| commit | d8f8b9542a4d8d560c0292a492f4edd922dd4ece (patch) | |
| tree | 79b535640308b6e1b9869f235f0b01c20c2b0230 /net/ipv4/ip_tunnel.c | |
| parent | Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue (diff) | |
| download | linux-dev-d8f8b9542a4d8d560c0292a492f4edd922dd4ece.tar.xz linux-dev-d8f8b9542a4d8d560c0292a492f4edd922dd4ece.zip | |
net: stmmac: do not use a bitwise AND operator with a bool operand
Doing a bitwise AND between a bool and an int is generally not a good idea.
The bool will be promoted to an int with value 0 or 1,
the int is generally regarded as true with a non-zero value,
thus ANDing them has the potential to yield an undesired result.
This commit fixes the following smatch warnings:
drivers/net/ethernet/stmicro/stmmac/enh_desc.c:344 enh_desc_prepare_tx_desc() warn: maybe use && instead of &
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:337 dwmac4_rd_prepare_tx_desc() warn: maybe use && instead of &
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:380 dwmac4_rd_prepare_tso_tx_desc() warn: maybe use && instead of &
Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_tunnel.c')
0 files changed, 0 insertions, 0 deletions