diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-18 10:26:40 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-20 10:14:49 +0100 |
| commit | 7998c12a08c97cc26660532c9f90a34bd7d8da5a (patch) | |
| tree | 01ca6251b1d6dbba4235c77a72c5b453bf0ccab5 /net/ipv4/route.c | |
| parent | ipv4: Fix a data-race around sysctl_fib_multipath_use_neigh. (diff) | |
| download | linux-dev-7998c12a08c97cc26660532c9f90a34bd7d8da5a.tar.xz linux-dev-7998c12a08c97cc26660532c9f90a34bd7d8da5a.zip | |
ipv4: Fix data-races around sysctl_fib_multipath_hash_policy.
While reading sysctl_fib_multipath_hash_policy, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its readers.
Fixes: bf4e0a3db97e ("net: ipv4: add support for ECMP hash policy choice")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/route.c')
| -rw-r--r-- | net/ipv4/route.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 91c4f60de75a..521194dd1c99 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2048,7 +2048,7 @@ int fib_multipath_hash(const struct net *net, const struct flowi4 *fl4, struct flow_keys hash_keys; u32 mhash = 0; - switch (net->ipv4.sysctl_fib_multipath_hash_policy) { + switch (READ_ONCE(net->ipv4.sysctl_fib_multipath_hash_policy)) { case 0: memset(&hash_keys, 0, sizeof(hash_keys)); hash_keys.control.addr_type = FLOW_DISSECTOR_KEY_IPV4_ADDRS; |