diff options
| author |   Jianzhao Wang <jianzhao.wang@6wind.com> | 2010-09-08 14:35:43 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2010-09-08 14:35:43 -0700 |
| commit | ae2688d59b5f861dc70a091d003773975d2ae7fb (patch) | |
| tree | ae674d926ba2069bc712cc1bb25b1c87ea7cc241 /net/ipv4/route.c | |
| parent | ipv4: Suppress lockdep-RCU false positive in FIB trie (3) (diff) | |
| download | linux-dev-ae2688d59b5f861dc70a091d003773975d2ae7fb.tar.xz linux-dev-ae2688d59b5f861dc70a091d003773975d2ae7fb.zip | |
net: blackhole route should always be recalculated
Blackhole routes are used when xfrm_lookup() returns -EREMOTE (error
triggered by IKE for example), hence this kind of route is always
temporary and so we should check if a better route exists for next
packets.
Bug has been introduced by commit d11a4dc18bf41719c9f0d7ed494d295dd2973b92.
Signed-off-by: Jianzhao Wang <jianzhao.wang@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/route.c')
| -rw-r--r-- | net/ipv4/route.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 3f56b6e6c6aa..6298f75d5e93 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2738,6 +2738,11 @@ slow_output: } EXPORT_SYMBOL_GPL(__ip_route_output_key); +static struct dst_entry *ipv4_blackhole_dst_check(struct dst_entry *dst, u32 cookie) +{ + return NULL; +} + static void ipv4_rt_blackhole_update_pmtu(struct dst_entry *dst, u32 mtu) { } @@ -2746,7 +2751,7 @@ static struct dst_ops ipv4_dst_blackhole_ops = { .family = AF_INET, .protocol = cpu_to_be16(ETH_P_IP), .destroy = ipv4_dst_destroy, - .check = ipv4_dst_check, + .check = ipv4_blackhole_dst_check, .update_pmtu = ipv4_rt_blackhole_update_pmtu, .entries = ATOMIC_INIT(0), }; |