diff options
| author |   Julia Lawall <julia@diku.dk> | 2008-01-08 23:48:20 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2008-01-28 15:01:05 -0800 |
| commit | 4cec72c890d3a465eed08c24a4a2bfe25650318f (patch) | |
| tree | 71cd934f540055e67f447f3fa2f95e66b13512e0 /net/ipv4/sysctl_net_ipv4.c | |
| parent | mac80211: Add radio led trigger (diff) | |
| download | linux-dev-4cec72c890d3a465eed08c24a4a2bfe25650318f.tar.xz linux-dev-4cec72c890d3a465eed08c24a4a2bfe25650318f.zip | |
[TIPC]: Use tipc_port_unlock
The file net/tipc/port.c takes a lock using the function tipc_port_lock and
then releases the lock sometimes using tipc_port_unlock and sometimes using
spin_unlock_bh(p_ptr->publ.lock). tipc_port_unlock simply does the
spin_unlock_bh, but it seems cleaner to use it everywhere.
The problem was fixed using the following semantic patch.
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
struct port *p_ptr;
@@
p_ptr = tipc_port_lock(...)
...
(
p_ptr = tipc_port_lock(...);
|
?- spin_unlock_bh(p_ptr->publ.lock);
+ tipc_port_unlock(p_ptr);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Jon Paul Maloy <maloy@donjonn.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/sysctl_net_ipv4.c')
0 files changed, 0 insertions, 0 deletions