diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2016-03-14 15:53:57 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-03-14 13:10:29 -0400 |
| commit | efc21d95067f658a20e51e24c4c86d68f23b7f7f (patch) | |
| tree | 67836a34b5fd852007bfc3b0315e99ca767bc864 /net/ipv4/tcp_fastopen.c | |
| parent | Merge branch 'net-gcc60-fixes' (diff) | |
| download | linux-dev-efc21d95067f658a20e51e24c4c86d68f23b7f7f.tar.xz linux-dev-efc21d95067f658a20e51e24c4c86d68f23b7f7f.zip | |
vmxnet3: fix lock imbalance in vmxnet3_tq_xmit()
A recent bug fix rearranged the code in vmxnet3_tq_xmit() in a
way that left the error handling for oversized headers unlock
a lock that had not been taken yet. Gcc warns about the incorrect
use of the 'flags' variable because of that:
drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_tq_xmit.constprop':
include/linux/spinlock.h:246:3: error: 'flags' may be used uninitialized in this function [-Werror=maybe-uninitialized]
This changes the error handling path to 'goto' the end of the function
beyond the lock/unlock pair.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: cec05562fb1d ("vmxnet3: avoid calling pskb_may_pull with interrupts disabled")
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_fastopen.c')
0 files changed, 0 insertions, 0 deletions