diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-22 11:22:02 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-25 12:42:10 +0100 |
| commit | 22396941a7f343d704738360f9ef0e6576489d43 (patch) | |
| tree | 70723212735e519a0ff8b80b00536d3c42558220 /net/ipv4/tcp_input.c | |
| parent | tcp: Fix a data-race around sysctl_tcp_comp_sack_delay_ns. (diff) | |
| download | linux-dev-22396941a7f343d704738360f9ef0e6576489d43.tar.xz linux-dev-22396941a7f343d704738360f9ef0e6576489d43.zip | |
tcp: Fix a data-race around sysctl_tcp_comp_sack_slack_ns.
While reading sysctl_tcp_comp_sack_slack_ns, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its reader.
Fixes: a70437cc09a1 ("tcp: add hrtimer slack to sack compression")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_input.c')
| -rw-r--r-- | net/ipv4/tcp_input.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 813744180d87..a4d8851d83ff 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -5547,7 +5547,7 @@ send_now: rtt * (NSEC_PER_USEC >> 3)/20); sock_hold(sk); hrtimer_start_range_ns(&tp->compressed_ack_timer, ns_to_ktime(delay), - sock_net(sk)->ipv4.sysctl_tcp_comp_sack_slack_ns, + READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_comp_sack_slack_ns), HRTIMER_MODE_REL_PINNED_SOFT); } |