diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-20 09:50:26 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-22 12:06:18 +0100 |
| commit | 2afdbe7b8de84c28e219073a6661080e1b3ded48 (patch) | |
| tree | 1671e0ab895d93a261db38e1ef1e4c313537fd9f /net/ipv4/tcp_input.c | |
| parent | tcp: Fix a data-race around sysctl_tcp_autocorking. (diff) | |
| download | linux-dev-2afdbe7b8de84c28e219073a6661080e1b3ded48.tar.xz linux-dev-2afdbe7b8de84c28e219073a6661080e1b3ded48.zip | |
tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit.
While reading sysctl_tcp_invalid_ratelimit, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its reader.
Fixes: 032ee4236954 ("tcp: helpers to mitigate ACK loops by rate-limiting out-of-window dupacks")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_input.c')
| -rw-r--r-- | net/ipv4/tcp_input.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 96d11f8ab729..c799f39cb774 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -3581,7 +3581,8 @@ static bool __tcp_oow_rate_limited(struct net *net, int mib_idx, if (*last_oow_ack_time) { s32 elapsed = (s32)(tcp_jiffies32 - *last_oow_ack_time); - if (0 <= elapsed && elapsed < net->ipv4.sysctl_tcp_invalid_ratelimit) { + if (0 <= elapsed && + elapsed < READ_ONCE(net->ipv4.sysctl_tcp_invalid_ratelimit)) { NET_INC_STATS(net, mib_idx); return true; /* rate-limited: don't send yet! */ } |