diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-11 17:15:30 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-13 12:56:49 +0100 |
| commit | 4785a66702f086cf2ea84bdbe6ec921f274bd9f2 (patch) | |
| tree | 28f36a4bf5f7825aacde839ad3286e1c1cec8a84 /net/ipv4/tcp_input.c | |
| parent | raw: Fix a data-race around sysctl_raw_l3mdev_accept. (diff) | |
| download | linux-dev-4785a66702f086cf2ea84bdbe6ec921f274bd9f2.tar.xz linux-dev-4785a66702f086cf2ea84bdbe6ec921f274bd9f2.zip | |
tcp: Fix data-races around sysctl_tcp_ecn.
While reading sysctl_tcp_ecn, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its readers.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_input.c')
| -rw-r--r-- | net/ipv4/tcp_input.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 2e2a9ece9af2..3ec4edc37313 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -6729,7 +6729,7 @@ static void tcp_ecn_create_request(struct request_sock *req, ect = !INET_ECN_is_not_ect(TCP_SKB_CB(skb)->ip_dsfield); ecn_ok_dst = dst_feature(dst, DST_FEATURE_ECN_MASK); - ecn_ok = net->ipv4.sysctl_tcp_ecn || ecn_ok_dst; + ecn_ok = READ_ONCE(net->ipv4.sysctl_tcp_ecn) || ecn_ok_dst; if (((!ect || th->res1) && ecn_ok) || tcp_ca_needs_ecn(listen_sk) || (ecn_ok_dst & DST_FEATURE_ECN_CA) || |