diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-18 10:26:50 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-20 10:14:50 +0100 |
| commit | 4e08ed41cb1194009fc1a916a59ce3ed4afd77cd (patch) | |
| tree | 44c348bc05215a783ea2b158b3d45acb2691b71c /net/ipv4/tcp_input.c | |
| parent | tcp: Fix a data-race around sysctl_tcp_retrans_collapse. (diff) | |
| download | linux-dev-4e08ed41cb1194009fc1a916a59ce3ed4afd77cd.tar.xz linux-dev-4e08ed41cb1194009fc1a916a59ce3ed4afd77cd.zip | |
tcp: Fix a data-race around sysctl_tcp_stdurg.
While reading sysctl_tcp_stdurg, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_input.c')
| -rw-r--r-- | net/ipv4/tcp_input.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 36eabd109e7c..31a9d2b8ecdc 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -5572,7 +5572,7 @@ static void tcp_check_urg(struct sock *sk, const struct tcphdr *th) struct tcp_sock *tp = tcp_sk(sk); u32 ptr = ntohs(th->urg_ptr); - if (ptr && !sock_net(sk)->ipv4.sysctl_tcp_stdurg) + if (ptr && !READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_stdurg)) ptr--; ptr += ntohl(th->seq); |