diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-18 10:26:46 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-20 10:14:50 +0100 |
| commit | e7d2ef837e14a971a05f60ea08c47f3fed1a36e4 (patch) | |
| tree | b31a9f6cf32b890ab218549be7a0800c59281dbc /net/ipv4/tcp_input.c | |
| parent | tcp: Fix a data-race around sysctl_tcp_early_retrans. (diff) | |
| download | linux-dev-e7d2ef837e14a971a05f60ea08c47f3fed1a36e4.tar.xz linux-dev-e7d2ef837e14a971a05f60ea08c47f3fed1a36e4.zip | |
tcp: Fix data-races around sysctl_tcp_recovery.
While reading sysctl_tcp_recovery, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its readers.
Fixes: 4f41b1c58a32 ("tcp: use RACK to detect losses")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_input.c')
| -rw-r--r-- | net/ipv4/tcp_input.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 92626e15115c..36eabd109e7c 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -2095,7 +2095,8 @@ static inline void tcp_init_undo(struct tcp_sock *tp) static bool tcp_is_rack(const struct sock *sk) { - return sock_net(sk)->ipv4.sysctl_tcp_recovery & TCP_RACK_LOSS_DETECTION; + return READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_recovery) & + TCP_RACK_LOSS_DETECTION; } /* If we detect SACK reneging, forget all SACK information |