diff options
| author |   Eric Dumazet <edumazet@google.com> | 2017-11-03 06:18:59 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-11-05 22:14:54 +0900 |
| commit | 35e00da36cf42d54270ce25110ce304d12b18586 (patch) | |
| tree | 6bd07d160416b06eb850310dea5819c69141ff79 /net/ipv4/tcp_output.c | |
| parent | tcp: tcp_mtu_probing() cleanup (diff) | |
| download | linux-dev-35e00da36cf42d54270ce25110ce304d12b18586.tar.xz linux-dev-35e00da36cf42d54270ce25110ce304d12b18586.zip | |
tcp: do not clear again skb->csum in tcp_init_nondata_skb()
tcp_init_nondata_skb() is fed with freshly allocated skbs.
They already have a cleared csum field, no need to clear it again.
This is based on Neal review on commit 3b11775033dc ("tcp: do not mangle
skb->cb[] in tcp_make_synack()"), noticing I did not clear skb->csum.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_output.c')
| -rw-r--r-- | net/ipv4/tcp_output.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index b98b2f7f07e7..a9d917e4dad5 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -381,7 +381,6 @@ static void tcp_ecn_send(struct sock *sk, struct sk_buff *skb, static void tcp_init_nondata_skb(struct sk_buff *skb, u32 seq, u8 flags) { skb->ip_summed = CHECKSUM_PARTIAL; - skb->csum = 0; TCP_SKB_CB(skb)->tcp_flags = flags; TCP_SKB_CB(skb)->sacked = 0; |