diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-18 10:26:48 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-20 10:14:50 +0100 |
| commit | 4845b5713ab18a1bb6e31d1fbb4d600240b8b691 (patch) | |
| tree | 3b1006f962476c31c415c8f357600aad22d32462 /net/ipv4/tcp_output.c | |
| parent | tcp: Fix a data-race around sysctl_tcp_thin_linear_timeouts. (diff) | |
| download | linux-dev-4845b5713ab18a1bb6e31d1fbb4d600240b8b691.tar.xz linux-dev-4845b5713ab18a1bb6e31d1fbb4d600240b8b691.zip | |
tcp: Fix data-races around sysctl_tcp_slow_start_after_idle.
While reading sysctl_tcp_slow_start_after_idle, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its readers.
Fixes: 35089bb203f4 ("[TCP]: Add tcp_slow_start_after_idle sysctl.")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_output.c')
| -rw-r--r-- | net/ipv4/tcp_output.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 898fcdcb7989..51120407c570 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -1898,7 +1898,7 @@ static void tcp_cwnd_validate(struct sock *sk, bool is_cwnd_limited) if (tp->packets_out > tp->snd_cwnd_used) tp->snd_cwnd_used = tp->packets_out; - if (sock_net(sk)->ipv4.sysctl_tcp_slow_start_after_idle && + if (READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_slow_start_after_idle) && (s32)(tcp_jiffies32 - tp->snd_cwnd_stamp) >= inet_csk(sk)->icsk_rto && !ca_ops->cong_control) tcp_cwnd_application_limited(sk); |