diff options
| author |   Eric Dumazet <edumazet@google.com> | 2019-10-10 20:17:40 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-10-13 10:13:08 -0700 |
| commit | 7db48e983930285b765743ebd665aecf9850582b (patch) | |
| tree | 3ee9dad33e8d9a0d27cc576a5f3ebf077f5af2d0 /net/ipv4/tcp_output.c | |
| parent | tcp: annotate tp->rcv_nxt lockless reads (diff) | |
| download | linux-dev-7db48e983930285b765743ebd665aecf9850582b.tar.xz linux-dev-7db48e983930285b765743ebd665aecf9850582b.zip | |
tcp: annotate tp->copied_seq lockless reads
There are few places where we fetch tp->copied_seq while
this field can change from IRQ or other cpu.
We need to add READ_ONCE() annotations, and also make
sure write sides use corresponding WRITE_ONCE() to avoid
store-tearing.
Note that tcp_inq_hint() was already using READ_ONCE(tp->copied_seq)
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_output.c')
| -rw-r--r-- | net/ipv4/tcp_output.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 84ae4d1449ea..7dda12720169 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -3433,7 +3433,7 @@ static void tcp_connect_init(struct sock *sk) else tp->rcv_tstamp = tcp_jiffies32; tp->rcv_wup = tp->rcv_nxt; - tp->copied_seq = tp->rcv_nxt; + WRITE_ONCE(tp->copied_seq, tp->rcv_nxt); inet_csk(sk)->icsk_rto = tcp_timeout_init(sk); inet_csk(sk)->icsk_retransmits = 0; |