diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-13 13:52:03 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-15 11:49:56 +0100 |
| commit | 8e92d4423615a5257d0d871fc067aa561f597deb (patch) | |
| tree | 231eaa5ebc1706e51ccb190dd86949429c316267 /net/ipv4/tcp_timer.c | |
| parent | tcp: Fix data-races around sysctl_tcp_min_snd_mss. (diff) | |
| download | linux-dev-8e92d4423615a5257d0d871fc067aa561f597deb.tar.xz linux-dev-8e92d4423615a5257d0d871fc067aa561f597deb.zip | |
tcp: Fix a data-race around sysctl_tcp_mtu_probe_floor.
While reading sysctl_tcp_mtu_probe_floor, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: c04b79b6cfd7 ("tcp: add new tcp_mtu_probe_floor sysctl")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_timer.c')
| -rw-r--r-- | net/ipv4/tcp_timer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c index 39107bb730b0..4f3b9ab222b6 100644 --- a/net/ipv4/tcp_timer.c +++ b/net/ipv4/tcp_timer.c @@ -172,7 +172,7 @@ static void tcp_mtu_probing(struct inet_connection_sock *icsk, struct sock *sk) } else { mss = tcp_mtu_to_mss(sk, icsk->icsk_mtup.search_low) >> 1; mss = min(READ_ONCE(net->ipv4.sysctl_tcp_base_mss), mss); - mss = max(mss, net->ipv4.sysctl_tcp_mtu_probe_floor); + mss = max(mss, READ_ONCE(net->ipv4.sysctl_tcp_mtu_probe_floor)); mss = max(mss, READ_ONCE(net->ipv4.sysctl_tcp_min_snd_mss)); icsk->icsk_mtup.search_low = tcp_mss_to_mtu(sk, mss); } |