aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4/xfrm4_protocol.c
diff options
context:
space:
mode:
authorMathias Krause <minipli@googlemail.com>2014-05-09 23:43:42 +0200
committerSteffen Klassert <steffen.klassert@secunet.com>2014-06-26 08:21:57 +0200
commit1990e4f883a6383b04ef37f32bdaa02dc0dbae8d (patch)
tree10df5de557e665e09809dbdf84b0938a68d5a72f /net/ipv4/xfrm4_protocol.c
parentvti6: Simplify error handling in module init and exit (diff)
downloadlinux-dev-1990e4f883a6383b04ef37f32bdaa02dc0dbae8d.tar.xz
linux-dev-1990e4f883a6383b04ef37f32bdaa02dc0dbae8d.zip
vti: Simplify error handling in module init and exit
The error handling in the module init and exit functions can be shortened to safe us some code. 1/ Remove the code duplications in the init function, jump straight to the existing cleanup code by adding some labels. Also give the error message some more value by telling the reason why loading the module has failed. Furthermore fix the "IPSec" typo -- it should be "IPsec" instead. 2/ Remove the error handling in the exit function as the only legitimate reason xfrm4_protocol_deregister() might fail is inet_del_protocol() returning -1. That, in turn, means some other protocol handler had been registered for this very protocol in the meantime. But that essentially means we haven't been handling that protocol any more, anyway. What it definitely means not is that we "can't deregister tunnel". Therefore just get rid of that bogus warning. It's plain wrong. Signed-off-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Diffstat (limited to 'net/ipv4/xfrm4_protocol.c')
0 files changed, 0 insertions, 0 deletions