diff options
| author |   Riccardo Paolo Bestetti <pbl@bestov.io> | 2022-06-19 18:27:35 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-06-20 09:58:12 +0100 |
| commit | 313c502fa3b3494159cb8f18d4a6444d06c5c9a5 (patch) | |
| tree | 402ca7acdf073d41fd46d34ee62233da5d214edd /net/ipv4 | |
| parent | net: phy: at803x: fix NULL pointer dereference on AR9331 PHY (diff) | |
| download | linux-dev-313c502fa3b3494159cb8f18d4a6444d06c5c9a5.tar.xz linux-dev-313c502fa3b3494159cb8f18d4a6444d06c5c9a5.zip | |
ipv4: fix bind address validity regression tests
Commit 8ff978b8b222 ("ipv4/raw: support binding to nonlocal addresses")
introduces support for binding to nonlocal addresses, as well as some
basic test coverage for some of the related cases.
Commit b4a028c4d031 ("ipv4: ping: fix bind address validity check")
fixes a regression which incorrectly removed some checks for bind
address validation. In addition, it introduces regression tests for
those specific checks. However, those regression tests are defective, in
that they perform the tests using an incorrect combination of bind
flags. As a result, those tests fail when they should succeed.
This commit introduces additional regression tests for nonlocal binding
and fixes the defective regression tests. It also introduces new
set_sysctl calls for the ipv4_bind test group, as to perform the ICMP
binding tests it is necessary to allow ICMP socket creation by setting
the net.ipv4.ping_group_range knob.
Fixes: b4a028c4d031 ("ipv4: ping: fix bind address validity check")
Reported-by: Riccardo Paolo Bestetti <pbl@bestov.io>
Signed-off-by: Riccardo Paolo Bestetti <pbl@bestov.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
0 files changed, 0 insertions, 0 deletions