diff options
| author |   Ido Schimmel <idosch@nvidia.com> | 2020-08-26 19:48:52 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-08-26 16:00:51 -0700 |
| commit | 33d80996b85283f90474d531920e40ccc2aab918 (patch) | |
| tree | 0a26a51da987eb31228538042a1639201e2a7f4c /net/ipv4 | |
| parent | ipv4: nexthop: Reduce allocation size of 'struct nh_group' (diff) | |
| download | linux-dev-33d80996b85283f90474d531920e40ccc2aab918.tar.xz linux-dev-33d80996b85283f90474d531920e40ccc2aab918.zip | |
ipv4: nexthop: Use nla_put_be32() for NHA_GATEWAY
The code correctly uses nla_get_be32() to get the payload of the
attribute, but incorrectly uses nla_put_u32() to add the attribute to
the payload. This results in the following warning:
net/ipv4/nexthop.c:279:59: warning: incorrect type in argument 3 (different base types)
net/ipv4/nexthop.c:279:59: expected unsigned int [usertype] value
net/ipv4/nexthop.c:279:59: got restricted __be32 [usertype] ipv4
Suppress the warning by using nla_put_be32().
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/nexthop.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c index d13730ff9aeb..0823643a7dec 100644 --- a/net/ipv4/nexthop.c +++ b/net/ipv4/nexthop.c @@ -276,7 +276,7 @@ static int nh_fill_node(struct sk_buff *skb, struct nexthop *nh, case AF_INET: fib_nh = &nhi->fib_nh; if (fib_nh->fib_nh_gw_family && - nla_put_u32(skb, NHA_GATEWAY, fib_nh->fib_nh_gw4)) + nla_put_be32(skb, NHA_GATEWAY, fib_nh->fib_nh_gw4)) goto nla_put_failure; break; |