diff options
| author |   YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> | 2007-11-20 17:30:31 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2007-11-20 17:30:31 -0800 |
| commit | 354faf0977397cea382e9e9c214fd028377d277b (patch) | |
| tree | 5b3082736caaf676dcee2618db8cfb127a213f55 /net/ipv4 | |
| parent | [IPV4] TCPMD5: Omit redundant NULL check for kfree() argument. (diff) | |
| download | linux-dev-354faf0977397cea382e9e9c214fd028377d277b.tar.xz linux-dev-354faf0977397cea382e9e9c214fd028377d277b.zip | |
[IPV4] TCPMD5: Use memmove() instead of memcpy() because we have overlaps.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/tcp_ipv4.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index ff360968b910..652c32368ccc 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -938,10 +938,10 @@ int tcp_v4_md5_do_del(struct sock *sk, __be32 addr) tp->md5sig_info->alloced4 = 0; } else if (tp->md5sig_info->entries4 != i) { /* Need to do some manipulation */ - memcpy(&tp->md5sig_info->keys4[i], - &tp->md5sig_info->keys4[i+1], - (tp->md5sig_info->entries4 - i) * - sizeof(struct tcp4_md5sig_key)); + memmove(&tp->md5sig_info->keys4[i], + &tp->md5sig_info->keys4[i+1], + (tp->md5sig_info->entries4 - i) * + sizeof(struct tcp4_md5sig_key)); } tcp_free_md5sig_pool(); return 0; |