diff options
| author |   Haishuang Yan <yanhaishuang@cmss.chinamobile.com> | 2017-12-20 10:07:00 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-12-20 13:56:39 -0500 |
| commit | 50670b6ee9bc4ae8f9ce3112b437987adf273245 (patch) | |
| tree | d44c34916c0fc090da488f5c783ea829c70c097a /net/ipv4 | |
| parent | ip6_gre: fix error path when ip6erspan_rcv failed (diff) | |
| download | linux-dev-50670b6ee9bc4ae8f9ce3112b437987adf273245.tar.xz linux-dev-50670b6ee9bc4ae8f9ce3112b437987adf273245.zip | |
ip_gre: fix potential memory leak in erspan_rcv
If md is NULL, tun_dst must be freed, otherwise it will cause memory
leak.
Fixes: 1a66a836da6 ("gre: add collect_md mode to ERSPAN tunnel")
Cc: William Tu <u9012063@gmail.com>
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/ip_gre.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 5c36b6745dbc..90c912307814 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -313,8 +313,10 @@ static int erspan_rcv(struct sk_buff *skb, struct tnl_ptk_info *tpi, return PACKET_REJECT; md = ip_tunnel_info_opts(&tun_dst->u.tun_info); - if (!md) + if (!md) { + dst_release((struct dst_entry *)tun_dst); return PACKET_REJECT; + } memcpy(md, pkt_md, sizeof(*md)); md->version = ver; |