diff options
| author |   David Ahern <dsahern@gmail.com> | 2017-05-21 10:12:05 -0600 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-05-22 12:12:20 -0400 |
| commit | d5d531cb50a848b9f6767fcd7ef0c7767b3e9b21 (patch) | |
| tree | 51d98689a245e63cd770a1562a1b62524abd4fbf /net/ipv6/ip6_fib.c | |
| parent | net: ipv6: Plumb extack through route add functions (diff) | |
| download | linux-dev-d5d531cb50a848b9f6767fcd7ef0c7767b3e9b21.tar.xz linux-dev-d5d531cb50a848b9f6767fcd7ef0c7767b3e9b21.zip | |
net: ipv6: Add extack messages for route add failures
Add messages for non-obvious errors (e.g, no need to add text for malloc
failures or ENODEV failures). This mostly covers the annoying EINVAL errors
Some message strings violate the 80-columns but searchable strings need to
trump that rule.
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_fib.c')
| -rw-r--r-- | net/ipv6/ip6_fib.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index c1197e167d3e..deea901746c8 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -498,6 +498,8 @@ static struct fib6_node *fib6_add_1(struct fib6_node *root, !ipv6_prefix_equal(&key->addr, addr, fn->fn_bit)) { if (!allow_create) { if (replace_required) { + NL_SET_ERR_MSG(extack, + "Can not replace route - no match found"); pr_warn("Can't replace route, no match found\n"); return ERR_PTR(-ENOENT); } @@ -544,6 +546,8 @@ static struct fib6_node *fib6_add_1(struct fib6_node *root, * That would keep IPv6 consistent with IPv4 */ if (replace_required) { + NL_SET_ERR_MSG(extack, + "Can not replace route - no match found"); pr_warn("Can't replace route, no match found\n"); return ERR_PTR(-ENOENT); } |