diff options
| author |   Haishuang Yan <yanhaishuang@cmss.chinamobile.com> | 2017-12-20 10:07:01 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-12-20 13:56:39 -0500 |
| commit | afb4c97d90e62f33b9f389aa0023f8478bb89db2 (patch) | |
| tree | 7186108a24361bf91dca64ae2e4accbd855e1264 /net/ipv6/ip6_gre.c | |
| parent | ip_gre: fix potential memory leak in erspan_rcv (diff) | |
| download | linux-dev-afb4c97d90e62f33b9f389aa0023f8478bb89db2.tar.xz linux-dev-afb4c97d90e62f33b9f389aa0023f8478bb89db2.zip | |
ip6_gre: fix potential memory leak in ip6erspan_rcv
If md is NULL, tun_dst must be freed, otherwise it will cause memory
leak.
Fixes: ef7baf5e083c ("ip6_gre: add ip6 erspan collect_md mode")
Cc: William Tu <u9012063@gmail.com>
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_gre.c')
| -rw-r--r-- | net/ipv6/ip6_gre.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index b7a79ddcf851..8451d00b210b 100644 --- a/net/ipv6/ip6_gre.c +++ b/net/ipv6/ip6_gre.c @@ -550,8 +550,10 @@ static int ip6erspan_rcv(struct sk_buff *skb, int gre_hdr_len, info = &tun_dst->u.tun_info; md = ip_tunnel_info_opts(info); - if (!md) + if (!md) { + dst_release((struct dst_entry *)tun_dst); return PACKET_REJECT; + } memcpy(md, pkt_md, sizeof(*md)); md->version = ver; |