diff options
| author |   Lorenzo Bianconi <lorenzo.bianconi@redhat.com> | 2019-01-28 22:23:48 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-01-30 14:00:02 -0800 |
| commit | feaf5c796b3f0240f10d0d6d0b686715fd58a05b (patch) | |
| tree | e8868e00fc33050a9a4e7a7cc6d4548dc1a3dda0 /net/ipv6/ip6_gre.c | |
| parent | ucc_geth: Reset BQL queue when stopping device (diff) | |
| download | linux-dev-feaf5c796b3f0240f10d0d6d0b686715fd58a05b.tar.xz linux-dev-feaf5c796b3f0240f10d0d6d0b686715fd58a05b.zip | |
net: ip_gre: always reports o_key to userspace
Erspan protocol (version 1 and 2) relies on o_key to configure
session id header field. However TUNNEL_KEY bit is cleared in
erspan_xmit since ERSPAN protocol does not set the key field
of the external GRE header and so the configured o_key is not reported
to userspace. The issue can be triggered with the following reproducer:
$ip link add erspan1 type erspan local 192.168.0.1 remote 192.168.0.2 \
key 1 seq erspan_ver 1
$ip link set erspan1 up
$ip -d link sh erspan1
erspan1@NONE: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1450 qdisc pfifo_fast state UNKNOWN mode DEFAULT
link/ether 52:aa:99:95:9a:b5 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 1500
erspan remote 192.168.0.2 local 192.168.0.1 ttl inherit ikey 0.0.0.1 iseq oseq erspan_index 0
Fix the issue adding TUNNEL_KEY bit to the o_flags parameter in
ipgre_fill_info
Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_gre.c')
0 files changed, 0 insertions, 0 deletions