diff options
| author |   Eric Dumazet <edumazet@google.com> | 2018-04-05 06:39:31 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-04-05 15:16:15 -0400 |
| commit | 537b361fbcbcc3cd6fe2bb47069fd292b9256d16 (patch) | |
| tree | dcd4df322c786cfd954ed1dd9e6de1d73b95e66d /net/ipv6/ip6_vti.c | |
| parent | ip6_tunnel: better validate user provided tunnel names (diff) | |
| download | linux-dev-537b361fbcbcc3cd6fe2bb47069fd292b9256d16.tar.xz linux-dev-537b361fbcbcc3cd6fe2bb47069fd292b9256d16.zip | |
vti6: better validate user provided tunnel names
Use valid_name() to make sure user does not provide illegal
device name.
Fixes: ed1efb2aefbb ("ipv6: Add support for IPsec virtual tunnel interfaces")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_vti.c')
| -rw-r--r-- | net/ipv6/ip6_vti.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c index 6ebb2e8777f4..c214ffec02f0 100644 --- a/net/ipv6/ip6_vti.c +++ b/net/ipv6/ip6_vti.c @@ -212,10 +212,13 @@ static struct ip6_tnl *vti6_tnl_create(struct net *net, struct __ip6_tnl_parm *p char name[IFNAMSIZ]; int err; - if (p->name[0]) + if (p->name[0]) { + if (!dev_valid_name(p->name)) + goto failed; strlcpy(name, p->name, IFNAMSIZ); - else + } else { sprintf(name, "ip6_vti%%d"); + } dev = alloc_netdev(sizeof(*t), name, NET_NAME_UNKNOWN, vti6_dev_setup); if (!dev) |