diff options
| author |   Eric Dumazet <edumazet@google.com> | 2016-07-08 05:18:24 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-07-09 18:12:25 -0400 |
| commit | fa17806cde76fb1087532f07e72aa757a30e0500 (patch) | |
| tree | 89493cdb11e72b554373adfa2de627407ef908e1 /net/ipv6/ip6mr.c | |
| parent | Merge branch 'bgmac-platform-device' (diff) | |
| download | linux-dev-fa17806cde76fb1087532f07e72aa757a30e0500.tar.xz linux-dev-fa17806cde76fb1087532f07e72aa757a30e0500.zip | |
ipv4: do not abuse GFP_ATOMIC in inet_netconf_notify_devconf()
inet_forward_change() runs with RTNL held.
We are allowed to sleep if required.
If we use __in_dev_get_rtnl() instead of __in_dev_get_rcu(),
we no longer have to use GFP_ATOMIC allocations in
inet_netconf_notify_devconf(), meaning we are less likely to miss
notifications under memory pressure, and wont touch precious memory
reserves either and risk dropping incoming packets.
inet_netconf_get_devconf() can also use GFP_KERNEL allocation.
Fixes: edc9e748934c ("rtnl/ipv4: use netconf msg to advertise forwarding status")
Fixes: 9e5511106f99 ("rtnl/ipv4: add support of RTM_GETNETCONF")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6mr.c')
0 files changed, 0 insertions, 0 deletions