diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-11 17:15:33 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-13 12:56:50 +0100 |
| commit | bdf00bf24bef9be1ca641a6390fd5487873e0d2e (patch) | |
| tree | a571db15de0e5ac08997aab9705356eff39685b6 /net/ipv6/route.c | |
| parent | ipv4: Fix data-races around sysctl_ip_dynaddr. (diff) | |
| download | linux-dev-bdf00bf24bef9be1ca641a6390fd5487873e0d2e.tar.xz linux-dev-bdf00bf24bef9be1ca641a6390fd5487873e0d2e.zip | |
nexthop: Fix data-races around nexthop_compat_mode.
While reading nexthop_compat_mode, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its readers.
Fixes: 4f80116d3df3 ("net: ipv4: add sysctl for nexthop api compatibility mode")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/route.c')
| -rw-r--r-- | net/ipv6/route.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 828355710c57..916417944ec8 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5741,7 +5741,7 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb, if (nexthop_is_blackhole(rt->nh)) rtm->rtm_type = RTN_BLACKHOLE; - if (net->ipv4.sysctl_nexthop_compat_mode && + if (READ_ONCE(net->ipv4.sysctl_nexthop_compat_mode) && rt6_fill_node_nexthop(skb, rt->nh, &nh_flags) < 0) goto nla_put_failure; |