diff options
| author |   Eric Dumazet <edumazet@google.com> | 2017-11-29 17:43:57 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-11-30 10:21:44 -0500 |
| commit | 3016dad75b48279e579117ee3ed566ba90a3b023 (patch) | |
| tree | 4c2a36224dedf6c03780dbfd5c33c9b7f8ff19e0 /net/ipv6/tcp_ipv6.c | |
| parent | act_sample: get rid of tcf_sample_cleanup_rcu() (diff) | |
| download | linux-dev-3016dad75b48279e579117ee3ed566ba90a3b023.tar.xz linux-dev-3016dad75b48279e579117ee3ed566ba90a3b023.zip | |
tcp: remove buggy call to tcp_v6_restore_cb()
tcp_v6_send_reset() expects to receive an skb with skb->cb[] layout as
used in TCP stack.
MD5 lookup uses tcp_v6_iif() and tcp_v6_sdif() and thus
TCP_SKB_CB(skb)->header.h6
This patch probably fixes RST packets sent on behalf of a timewait md5
ipv6 socket.
Before Florian patch, tcp_v6_restore_cb() was needed before jumping to
no_tcp_socket label.
Fixes: 271c3b9b7bda ("tcp: honour SO_BINDTODEVICE for TW_RST case too")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Florian Westphal <fw@strlen.de>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/tcp_ipv6.c')
| -rw-r--r-- | net/ipv6/tcp_ipv6.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 6bb98c93edfe..be11dc13aa70 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c @@ -1590,7 +1590,6 @@ do_time_wait: tcp_v6_timewait_ack(sk, skb); break; case TCP_TW_RST: - tcp_v6_restore_cb(skb); tcp_v6_send_reset(sk, skb); inet_twsk_deschedule_put(inet_twsk(sk)); goto discard_it; |