diff options
| author |   Cong Wang <amwang@redhat.com> | 2013-05-09 22:40:00 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-05-11 17:40:15 -0700 |
| commit | 84c4a9dfbf430861e7588d95ae3ff61535dca351 (patch) | |
| tree | 1fce44619878ee08fa6ddef23d8fcd4f84e95ba5 /net/ipv6/xfrm6_policy.c | |
| parent | ipv6,gre: do not leak info to user-space (diff) | |
| download | linux-dev-84c4a9dfbf430861e7588d95ae3ff61535dca351.tar.xz linux-dev-84c4a9dfbf430861e7588d95ae3ff61535dca351.zip | |
xfrm6: release dev before returning error
We forget to call dev_put() on error path in xfrm6_fill_dst(),
its caller doesn't handle this.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/xfrm6_policy.c')
| -rw-r--r-- | net/ipv6/xfrm6_policy.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index 4ef7bdb65440..23ed03d786c8 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6/xfrm6_policy.c @@ -103,8 +103,10 @@ static int xfrm6_fill_dst(struct xfrm_dst *xdst, struct net_device *dev, dev_hold(dev); xdst->u.rt6.rt6i_idev = in6_dev_get(dev); - if (!xdst->u.rt6.rt6i_idev) + if (!xdst->u.rt6.rt6i_idev) { + dev_put(dev); return -ENODEV; + } rt6_transfer_peer(&xdst->u.rt6, rt); |