diff options
| author |   Eric Dumazet <edumazet@google.com> | 2018-10-05 09:17:50 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-10-05 11:57:11 -0700 |
| commit | fda21d46cce2879dbce981978f8cb07b36035369 (patch) | |
| tree | 9b8049c49b143525c3e511c3b9125dd829a4f801 /net/ipv6 | |
| parent | udp: gro behind static key (diff) | |
| download | linux-dev-fda21d46cce2879dbce981978f8cb07b36035369.tar.xz linux-dev-fda21d46cce2879dbce981978f8cb07b36035369.zip | |
ipv6: do not leave garbage in rt->fib6_metrics
In case ip_fib_metrics_init() returns an error, we better
rewrite rt->fib6_metrics with &dst_default_metrics so that
we do not crash later in ip_fib_metrics_put()
Fixes: 767a2217533f ("net: common metrics init helper for FIB entries")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6')
| -rw-r--r-- | net/ipv6/route.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 6c1d817151ca..74d97addf1af 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2976,6 +2976,8 @@ static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg, rt->fib6_metrics = ip_fib_metrics_init(net, cfg->fc_mx, cfg->fc_mx_len); if (IS_ERR(rt->fib6_metrics)) { err = PTR_ERR(rt->fib6_metrics); + /* Do not leave garbage there. */ + rt->fib6_metrics = (struct dst_metrics *)&dst_default_metrics; goto out; } |