diff options
| author |   Tom Parkin <tparkin@katalix.com> | 2020-07-23 12:29:55 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-07-23 11:54:40 -0700 |
| commit | 70c05bfa4a3d36c0d8e7cef86b0f6c8a9cbb8881 (patch) | |
| tree | b5b27ef6eeb2de26adbd523121c709b3547747be /net/l2tp/l2tp_core.c | |
| parent | l2tp: cleanup netlink tunnel create address handling (diff) | |
| download | linux-dev-70c05bfa4a3d36c0d8e7cef86b0f6c8a9cbb8881.tar.xz linux-dev-70c05bfa4a3d36c0d8e7cef86b0f6c8a9cbb8881.zip | |
l2tp: cleanup kzalloc calls
Passing "sizeof(struct blah)" in kzalloc calls is less readable,
potentially prone to future bugs if the type of the pointer is changed,
and triggers checkpatch warnings.
Tweak the kzalloc calls in l2tp which use this form to avoid the
warning.
Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/l2tp/l2tp_core.c')
| -rw-r--r-- | net/l2tp/l2tp_core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c index d1403f27135e..7e3523015d6f 100644 --- a/net/l2tp/l2tp_core.c +++ b/net/l2tp/l2tp_core.c @@ -1410,7 +1410,7 @@ int l2tp_tunnel_create(struct net *net, int fd, int version, u32 tunnel_id, u32 if (cfg) encap = cfg->encap; - tunnel = kzalloc(sizeof(struct l2tp_tunnel), GFP_KERNEL); + tunnel = kzalloc(sizeof(*tunnel), GFP_KERNEL); if (!tunnel) { err = -ENOMEM; goto err; @@ -1647,7 +1647,7 @@ struct l2tp_session *l2tp_session_create(int priv_size, struct l2tp_tunnel *tunn { struct l2tp_session *session; - session = kzalloc(sizeof(struct l2tp_session) + priv_size, GFP_KERNEL); + session = kzalloc(sizeof(*session) + priv_size, GFP_KERNEL); if (session) { session->magic = L2TP_SESSION_MAGIC; session->tunnel = tunnel; |