diff options
| author |   Guillaume Nault <g.nault@alphalink.fr> | 2018-04-12 20:50:33 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-04-13 12:17:26 -0400 |
| commit | 5846c131c39b6d0add36ec19dc8650700690f930 (patch) | |
| tree | d8bbddb871da06b66202ebaf67527dcb3267f19b /net/l2tp/l2tp_core.h | |
| parent | virtio-net: add missing virtqueue kick when flushing packets (diff) | |
| download | linux-dev-5846c131c39b6d0add36ec19dc8650700690f930.tar.xz linux-dev-5846c131c39b6d0add36ec19dc8650700690f930.zip | |
l2tp: hold reference on tunnels in netlink dumps
l2tp_tunnel_find_nth() is unsafe: no reference is held on the returned
tunnel, therefore it can be freed whenever the caller uses it.
This patch defines l2tp_tunnel_get_nth() which works similarly, but
also takes a reference on the returned tunnel. The caller then has to
drop it after it stops using the tunnel.
Convert netlink dumps to make them safe against concurrent tunnel
deletion.
Fixes: 309795f4bec2 ("l2tp: Add netlink control API for L2TP")
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/l2tp/l2tp_core.h')
| -rw-r--r-- | net/l2tp/l2tp_core.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/l2tp/l2tp_core.h b/net/l2tp/l2tp_core.h index ba33cbec71eb..e4896413b2b6 100644 --- a/net/l2tp/l2tp_core.h +++ b/net/l2tp/l2tp_core.h @@ -212,6 +212,8 @@ static inline void *l2tp_session_priv(struct l2tp_session *session) } struct l2tp_tunnel *l2tp_tunnel_get(const struct net *net, u32 tunnel_id); +struct l2tp_tunnel *l2tp_tunnel_get_nth(const struct net *net, int nth); + void l2tp_tunnel_free(struct l2tp_tunnel *tunnel); struct l2tp_session *l2tp_session_get(const struct net *net, |