diff options
| author |   Felix Fietkau <nbd@nbd.name> | 2021-01-26 16:44:09 +0100 |
|---|---|---|
| committer |   Johannes Berg <johannes.berg@intel.com> | 2021-01-27 22:06:38 +0100 |
| commit | d3b9b45f7e981bcc6355414c63633fe33d95660c (patch) | |
| tree | f854c66be070893b5080c65b66ef10034b114141 /net/mac80211/rc80211_minstrel_ht.c | |
| parent | virt_wifi: fix deadlock on RTNL (diff) | |
| download | linux-dev-d3b9b45f7e981bcc6355414c63633fe33d95660c.tar.xz linux-dev-d3b9b45f7e981bcc6355414c63633fe33d95660c.zip | |
mac80211: minstrel_ht: fix regression in the max_prob_rate fix
Since mi->max_prob_rate is overwritten after the loop that calls
minstrel_ht_set_best_prob_rate, the new best rate needs to be written to *dest
Fixes: a7fca4e4037f ("mac80211: minstrel_ht: fix max probability rate selection")
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20210126154409.6755-1-nbd@nbd.name
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211/rc80211_minstrel_ht.c')
| -rw-r--r-- | net/mac80211/rc80211_minstrel_ht.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c index e35948f4e1bf..bfa550068de4 100644 --- a/net/mac80211/rc80211_minstrel_ht.c +++ b/net/mac80211/rc80211_minstrel_ht.c @@ -537,7 +537,7 @@ minstrel_ht_set_best_prob_rate(struct minstrel_ht_sta *mi, u16 *dest, u16 index) cur_tp_avg = minstrel_ht_get_tp_avg(mi, cur_group, cur_idx, mrs->prob_avg); if (cur_tp_avg > tmp_tp_avg) - mi->max_prob_rate = index; + *dest = index; max_gpr_tp_avg = minstrel_ht_get_tp_avg(mi, max_gpr_group, max_gpr_idx, |