diff options
| author |   Antonio Quartulli <ordex@autistici.org> | 2012-10-26 18:54:25 +0200 |
|---|---|---|
| committer |   Johannes Berg <johannes.berg@intel.com> | 2012-10-26 22:52:18 +0200 |
| commit | badecb001a310408d3473b1fc2ed5aefd0bc92a9 (patch) | |
| tree | 3c39faabf192afce572be53b96bb65ad07ea7183 /net/mac80211 | |
| parent | mac80211: don't inspect Sequence Control field on control frames (diff) | |
| download | linux-dev-badecb001a310408d3473b1fc2ed5aefd0bc92a9.tar.xz linux-dev-badecb001a310408d3473b1fc2ed5aefd0bc92a9.zip | |
mac80211: fix SSID copy on IBSS JOIN
The 'ssid' field of the cfg80211_ibss_params is a u8 pointer and
its length is likely to be less than IEEE80211_MAX_SSID_LEN most
of the time.
This patch fixes the ssid copy in ieee80211_ibss_join() by using
the SSID length to prevent it from reading beyond the string.
Cc: stable@vger.kernel.org
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
[rewrapped commit message, small rewording]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211')
| -rw-r--r-- | net/mac80211/ibss.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c index 5f3620f0bc0a..bf87c70ac6c5 100644 --- a/net/mac80211/ibss.c +++ b/net/mac80211/ibss.c @@ -1108,7 +1108,7 @@ int ieee80211_ibss_join(struct ieee80211_sub_if_data *sdata, sdata->u.ibss.state = IEEE80211_IBSS_MLME_SEARCH; sdata->u.ibss.ibss_join_req = jiffies; - memcpy(sdata->u.ibss.ssid, params->ssid, IEEE80211_MAX_SSID_LEN); + memcpy(sdata->u.ibss.ssid, params->ssid, params->ssid_len); sdata->u.ibss.ssid_len = params->ssid_len; mutex_unlock(&sdata->u.ibss.mtx); |