diff options
| author |   Alexander Aring <alex.aring@gmail.com> | 2014-11-09 08:36:59 +0100 |
|---|---|---|
| committer |   Marcel Holtmann <marcel@holtmann.org> | 2014-11-09 19:50:29 +0100 |
| commit | f7cb96f105fb406e8db5e68e0cdd5067e2556d34 (patch) | |
| tree | e17cee80d85dc1aefdc7d8710a1210e3cb6a66f7 /net/mac802154 | |
| parent | ieee802154: fix iface dump with lowpan (diff) | |
| download | linux-dev-f7cb96f105fb406e8db5e68e0cdd5067e2556d34.tar.xz linux-dev-f7cb96f105fb406e8db5e68e0cdd5067e2556d34.zip | |
mac802154: protect address changes via ioctl
This patch adds a netif_running check while trying to change the address
attributes via ioctl. While netif_running is true these attributes
should be only readable.
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'net/mac802154')
| -rw-r--r-- | net/mac802154/iface.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/net/mac802154/iface.c b/net/mac802154/iface.c index d635f367b03f..83715b5ffe43 100644 --- a/net/mac802154/iface.c +++ b/net/mac802154/iface.c @@ -63,6 +63,8 @@ mac802154_wpan_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) (struct sockaddr_ieee802154 *)&ifr->ifr_addr; int err = -ENOIOCTLCMD; + ASSERT_RTNL(); + spin_lock_bh(&sdata->mib_lock); switch (cmd) { @@ -87,6 +89,11 @@ mac802154_wpan_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) break; } case SIOCSIFADDR: + if (netif_running(dev)) { + spin_unlock_bh(&sdata->mib_lock); + return -EBUSY; + } + dev_warn(&dev->dev, "Using DEBUGing ioctl SIOCSIFADDR isn't recommended!\n"); if (sa->family != AF_IEEE802154 || |