diff options
| author |   Gao Feng <fgao@ikuai8.com> | 2017-03-24 07:05:12 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-03-24 13:29:16 -0700 |
| commit | c48367427a39ea0b85c7cf018fe4256627abfd9e (patch) | |
| tree | 740f51767793ae5765a0ecedc931c1704d0bbf06 /net/mpls/af_mpls.c | |
| parent | net: make in_aton() 32-bit internally (diff) | |
| download | linux-dev-c48367427a39ea0b85c7cf018fe4256627abfd9e.tar.xz linux-dev-c48367427a39ea0b85c7cf018fe4256627abfd9e.zip | |
tcp: sysctl: Fix a race to avoid unexpected 0 window from space
Because sysctl_tcp_adv_win_scale could be changed any time, so there
is one race in tcp_win_from_space.
For example,
1.sysctl_tcp_adv_win_scale<=0 (sysctl_tcp_adv_win_scale is negative now)
2.space>>(-sysctl_tcp_adv_win_scale) (sysctl_tcp_adv_win_scale is postive now)
As a result, tcp_win_from_space returns 0. It is unexpected.
Certainly if the compiler put the sysctl_tcp_adv_win_scale into one
register firstly, then use the register directly, it would be ok.
But we could not depend on the compiler behavior.
Signed-off-by: Gao Feng <fgao@ikuai8.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/mpls/af_mpls.c')
0 files changed, 0 insertions, 0 deletions