aboutsummaryrefslogtreecommitdiffstats
path: root/net/mptcp/pm_netlink.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2022-07-06 12:20:59 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2022-07-07 09:53:43 -0700
commita382f8fee42ca10c9bfce0d2352d4153f931f5dc (patch)
tree82af0ff4d9345680b1f000650f6e6cbd3bff0f60 /net/mptcp/pm_netlink.c
parentMerge tag 'for-linus' of https://github.com/openrisc/linux (diff)
downloadlinux-dev-a382f8fee42ca10c9bfce0d2352d4153f931f5dc.tar.xz
linux-dev-a382f8fee42ca10c9bfce0d2352d4153f931f5dc.zip
signal handling: don't use BUG_ON() for debugging
These are indeed "should not happen" situations, but it turns out recent changes made the 'task_is_stopped_or_trace()' case trigger (fix for that exists, is pending more testing), and the BUG_ON() makes it unnecessarily hard to actually debug for no good reason. It's been that way for a long time, but let's make it clear: BUG_ON() is not good for debugging, and should never be used in situations where you could just say "this shouldn't happen, but we can continue". Use WARN_ON_ONCE() instead to make sure it gets logged, and then just continue running. Instead of making the system basically unusuable because you crashed the machine while potentially holding some very core locks (eg this function is commonly called while holding 'tasklist_lock' for writing). Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/mptcp/pm_netlink.c')
0 files changed, 0 insertions, 0 deletions