diff options
| author |   Paolo Abeni <pabeni@redhat.com> | 2022-05-04 14:54:07 -0700 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2022-05-05 19:00:15 -0700 |
| commit | f3589be0c420a3137e5902d15705ced6a36f3f43 (patch) | |
| tree | 979fd53649b562923da3d0f70013f98948c62b0f /net/mptcp/protocol.h | |
| parent | tcp: allow MPTCP to update the announced window (diff) | |
| download | linux-dev-f3589be0c420a3137e5902d15705ced6a36f3f43.tar.xz linux-dev-f3589be0c420a3137e5902d15705ced6a36f3f43.zip | |
mptcp: never shrink offered window
As per RFC, the offered MPTCP-level window should never shrink.
While we currently track the right edge, we don't enforce the
above constraint on the wire.
Additionally, concurrent xmit on different subflows can end-up in
erroneous right edge update.
Address the above explicitly updating the announced window and
protecting the update with an additional atomic operation (sic)
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/mptcp/protocol.h')
| -rw-r--r-- | net/mptcp/protocol.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h index f542aeaa5b09..4672901d0dfe 100644 --- a/net/mptcp/protocol.h +++ b/net/mptcp/protocol.h @@ -257,7 +257,7 @@ struct mptcp_sock { u64 write_seq; u64 snd_nxt; u64 ack_seq; - u64 rcv_wnd_sent; + atomic64_t rcv_wnd_sent; u64 rcv_data_fin_seq; int rmem_fwd_alloc; struct sock *last_snd; |