diff options
| author |   Geliang Tang <geliangtang@gmail.com> | 2021-03-30 17:08:51 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-03-30 17:42:23 -0700 |
| commit | 774c8a8dcb3cba72e37394dbc7803fe575e1292c (patch) | |
| tree | 4aed532518932037c4f5793043e5f75e82cf0ea7 /net/mptcp | |
| parent | net: fix icmp_echo_enable_probe sysctl (diff) | |
| download | linux-dev-774c8a8dcb3cba72e37394dbc7803fe575e1292c.tar.xz linux-dev-774c8a8dcb3cba72e37394dbc7803fe575e1292c.zip | |
mptcp: remove all subflows involving id 0 address
There's only one subflow involving the non-zero id address, but there
may be multi subflows involving the id 0 address.
Here's an example:
local_id=0, remote_id=0
local_id=1, remote_id=0
local_id=0, remote_id=1
If the removing address id is 0, all the subflows involving the id 0
address need to be removed.
In mptcp_pm_nl_rm_addr_received/mptcp_pm_nl_rm_subflow_received, the
"break" prevents the iteration to the next subflow, so this patch
dropped them.
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/mptcp')
| -rw-r--r-- | net/mptcp/pm_netlink.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index 73b9245c87b2..87a6133fd778 100644 --- a/net/mptcp/pm_netlink.c +++ b/net/mptcp/pm_netlink.c @@ -621,8 +621,6 @@ static void mptcp_pm_nl_rm_addr_received(struct mptcp_sock *msk) WRITE_ONCE(msk->pm.accept_addr, true); __MPTCP_INC_STATS(sock_net(sk), MPTCP_MIB_RMADDR); - - break; } } } @@ -695,8 +693,6 @@ void mptcp_pm_nl_rm_subflow_received(struct mptcp_sock *msk, msk->pm.subflows--; __MPTCP_INC_STATS(sock_net(sk), MPTCP_MIB_RMSUBFLOW); - - break; } } } |