diff options
| author |   Patrick McHardy <kaber@trash.net> | 2006-12-02 22:05:25 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2006-12-02 22:05:25 -0800 |
| commit | 9457d851fc5df54522d733f72cbb1f02ab59272e (patch) | |
| tree | 42a460d65cbb45b100c43f97ba8a7490df844bb8 /net/netfilter/nf_conntrack_helper.c | |
| parent | [NETFILTER]: nf_conntrack: endian annotations (diff) | |
| download | linux-dev-9457d851fc5df54522d733f72cbb1f02ab59272e.tar.xz linux-dev-9457d851fc5df54522d733f72cbb1f02ab59272e.zip | |
[NETFILTER]: nf_conntrack: automatic helper assignment for expectations
Some helpers (namely H.323) manually assign further helpers to expected
connections. This is not possible with nf_conntrack anymore since we
need to know whether a helper is used at allocation time.
Handle the helper assignment centrally, which allows to perform the
correct allocation and as a nice side effect eliminates the need
for the H.323 helper to fiddle with nf_conntrack_lock.
Mid term the allocation scheme really needs to be redesigned since
we do both the helper and expectation lookup _twice_ for every new
connection.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netfilter/nf_conntrack_helper.c')
| -rw-r--r-- | net/netfilter/nf_conntrack_helper.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c index 2628f4ba35ee..81542dc75069 100644 --- a/net/netfilter/nf_conntrack_helper.c +++ b/net/netfilter/nf_conntrack_helper.c @@ -129,7 +129,8 @@ void nf_conntrack_helper_unregister(struct nf_conntrack_helper *me) /* Get rid of expectations */ list_for_each_entry_safe(exp, tmp, &nf_conntrack_expect_list, list) { struct nf_conn_help *help = nfct_help(exp->master); - if (help->helper == me && del_timer(&exp->timeout)) { + if ((help->helper == me || exp->helper == me) && + del_timer(&exp->timeout)) { nf_ct_unlink_expect(exp); nf_conntrack_expect_put(exp); } |