diff options
| author |   Jules Irenge <jbi.octave@gmail.com> | 2020-03-11 01:09:04 +0000 |
|---|---|---|
| committer |   Pablo Neira Ayuso <pablo@netfilter.org> | 2020-03-27 18:21:09 +0100 |
| commit | 19f8f717f620576ada10b0ba8f4d55ef1208571e (patch) | |
| tree | b032c333218b1f7f2b2087e56489219624be8dd5 /net/netfilter/nf_conntrack_netlink.c | |
| parent | netfilter: flowtable: fix NULL pointer dereference in tunnel offload support (diff) | |
| download | linux-dev-19f8f717f620576ada10b0ba8f4d55ef1208571e.tar.xz linux-dev-19f8f717f620576ada10b0ba8f4d55ef1208571e.zip | |
netfilter: ctnetlink: Add missing annotation for ctnetlink_parse_nat_setup()
Sparse reports a warning at ctnetlink_parse_nat_setup()
warning: context imbalance in ctnetlink_parse_nat_setup()
- unexpected unlock
The root cause is the missing annotation at ctnetlink_parse_nat_setup()
Add the missing __must_hold(RCU) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter/nf_conntrack_netlink.c')
| -rw-r--r-- | net/netfilter/nf_conntrack_netlink.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 6a1c8f1f6171..eb190206cd12 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -1533,6 +1533,7 @@ static int ctnetlink_parse_nat_setup(struct nf_conn *ct, enum nf_nat_manip_type manip, const struct nlattr *attr) + __must_hold(RCU) { struct nf_nat_hook *nat_hook; int err; |