diff options
| author |   Aaron Conole <aconole@bytheb.org> | 2016-09-21 11:35:04 -0400 |
|---|---|---|
| committer |   Pablo Neira Ayuso <pablo@netfilter.org> | 2016-09-24 21:29:53 +0200 |
| commit | e2361cb90a0327bdab34d01d1a7b9dbd67c31e60 (patch) | |
| tree | d7f8b55fd607e5cb1c0018fa8f1f79d6038d17b3 /net/netfilter/nfnetlink_cthelper.c | |
| parent | netfilter: call nf_hook_ingress with rcu_read_lock (diff) | |
| download | linux-dev-e2361cb90a0327bdab34d01d1a7b9dbd67c31e60.tar.xz linux-dev-e2361cb90a0327bdab34d01d1a7b9dbd67c31e60.zip | |
netfilter: Remove explicit rcu_read_lock in nf_hook_slow
All of the callers of nf_hook_slow already hold the rcu_read_lock, so this
cleanup removes the recursive call. This is just a cleanup, as the locking
code gracefully handles this situation.
Signed-off-by: Aaron Conole <aconole@bytheb.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter/nfnetlink_cthelper.c')
| -rw-r--r-- | net/netfilter/nfnetlink_cthelper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nfnetlink_cthelper.c b/net/netfilter/nfnetlink_cthelper.c index e924e95fcc7f..3b79f34b5095 100644 --- a/net/netfilter/nfnetlink_cthelper.c +++ b/net/netfilter/nfnetlink_cthelper.c @@ -43,7 +43,7 @@ nfnl_userspace_cthelper(struct sk_buff *skb, unsigned int protoff, if (help == NULL) return NF_DROP; - /* rcu_read_lock()ed by nf_hook_slow */ + /* rcu_read_lock()ed by nf_hook_thresh */ helper = rcu_dereference(help->helper); if (helper == NULL) return NF_DROP; |