aboutsummaryrefslogtreecommitdiffstats
path: root/net/netfilter/nft_hash.c
diff options
context:
space:
mode:
authorLaura Garcia Liebana <nevola@gmail.com>2018-04-23 12:48:07 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2018-05-06 23:31:54 +0200
commit75e72f05418afbeac0a707d2e0cc9451ceb47e43 (patch)
treebc19fa84f2b1a9145bfdb2e70f4d835907d315cb /net/netfilter/nft_hash.c
parentnetfilter: nft_numgen: add map lookups for numgen statements (diff)
downloadlinux-dev-75e72f05418afbeac0a707d2e0cc9451ceb47e43.tar.xz
linux-dev-75e72f05418afbeac0a707d2e0cc9451ceb47e43.zip
netfilter: nft_numgen: enable hashing of one element
The modulus in the hash function was limited to > 1 as initially there was no sense to create a hashing of just one element. Nevertheless, there are certain cases specially for load balancing where this case needs to be addressed. This patch fixes the following error. Error: Could not process rule: Numerical result out of range add rule ip nftlb lb01 dnat to jhash ip saddr mod 1 map { 0: 192.168.0.10 } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The solution comes to force the hash to 0 when the modulus is 1. Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
Diffstat (limited to 'net/netfilter/nft_hash.c')
-rw-r--r--net/netfilter/nft_hash.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nft_hash.c b/net/netfilter/nft_hash.c
index 24f2f7567ddb..e235c17f1b8b 100644
--- a/net/netfilter/nft_hash.c
+++ b/net/netfilter/nft_hash.c
@@ -97,7 +97,7 @@ static int nft_jhash_init(const struct nft_ctx *ctx,
priv->len = len;
priv->modulus = ntohl(nla_get_be32(tb[NFTA_HASH_MODULUS]));
- if (priv->modulus <= 1)
+ if (priv->modulus < 1)
return -ERANGE;
if (priv->offset + priv->modulus - 1 < priv->offset)