diff options
| author |   Jan Engelhardt <jengelh@medozas.de> | 2010-03-23 17:40:13 +0100 |
|---|---|---|
| committer | Jan Engelhardt <jengelh@medozas.de> | 2010-03-25 16:03:12 +0100 |
| commit | 9f5673174161cc026a6c87f70d9b457e7ad82a80 (patch) | |
| tree | c0f763f86b93a476837193c4621f431960745ff1 /net/netfilter/xt_dccp.c | |
| parent | netfilter: ipvs: use NFPROTO values for NF_HOOK invocation (diff) | |
| download | linux-dev-9f5673174161cc026a6c87f70d9b457e7ad82a80.tar.xz linux-dev-9f5673174161cc026a6c87f70d9b457e7ad82a80.zip | |
netfilter: xtables: untangle spaghetti if clauses in checkentry
As I'm changing the return values soon, I want to have a clear visual
path.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Diffstat (limited to 'net/netfilter/xt_dccp.c')
| -rw-r--r-- | net/netfilter/xt_dccp.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/net/netfilter/xt_dccp.c b/net/netfilter/xt_dccp.c index 0989f29ade2e..8f6014f7c881 100644 --- a/net/netfilter/xt_dccp.c +++ b/net/netfilter/xt_dccp.c @@ -127,9 +127,13 @@ static bool dccp_mt_check(const struct xt_mtchk_param *par) { const struct xt_dccp_info *info = par->matchinfo; - return !(info->flags & ~XT_DCCP_VALID_FLAGS) - && !(info->invflags & ~XT_DCCP_VALID_FLAGS) - && !(info->invflags & ~info->flags); + if (info->flags & ~XT_DCCP_VALID_FLAGS) + return false; + if (info->invflags & ~XT_DCCP_VALID_FLAGS) + return false; + if (info->invflags & ~info->flags) + return false; + return true; } static struct xt_match dccp_mt_reg[] __read_mostly = { |