diff options
| author |   Flavio Leitner <fbl@redhat.com> | 2018-06-27 10:34:25 -0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-06-28 22:21:32 +0900 |
| commit | f564650106a6e85702660fefd59fdff0877ab46a (patch) | |
| tree | 5bc5ca2ef701a097f0447a7073c2ee0be9b79e01 /net/netfilter/xt_owner.c | |
| parent | Merge branch 'net-sched-actions-code-style-cleanup-and-fixes' (diff) | |
| download | linux-dev-f564650106a6e85702660fefd59fdff0877ab46a.tar.xz linux-dev-f564650106a6e85702660fefd59fdff0877ab46a.zip | |
netfilter: check if the socket netns is correct.
Netfilter assumes that if the socket is present in the skb, then
it can be used because that reference is cleaned up while the skb
is crossing netns.
We want to change that to preserve the socket reference in a future
patch, so this is a preparation updating netfilter to check if the
socket netns matches before use it.
Signed-off-by: Flavio Leitner <fbl@redhat.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netfilter/xt_owner.c')
| -rw-r--r-- | net/netfilter/xt_owner.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/xt_owner.c b/net/netfilter/xt_owner.c index 3d705c688a27..46686fb73784 100644 --- a/net/netfilter/xt_owner.c +++ b/net/netfilter/xt_owner.c @@ -67,7 +67,7 @@ owner_mt(const struct sk_buff *skb, struct xt_action_param *par) struct sock *sk = skb_to_full_sk(skb); struct net *net = xt_net(par); - if (sk == NULL || sk->sk_socket == NULL) + if (!sk || !sk->sk_socket || !net_eq(net, sock_net(sk))) return (info->match ^ info->invert) == 0; else if (info->match & info->invert & XT_OWNER_SOCKET) /* |