diff options
| author |   Eric Dumazet <eric.dumazet@gmail.com> | 2010-02-19 15:28:38 +0100 |
|---|---|---|
| committer |   Patrick McHardy <kaber@trash.net> | 2010-02-19 15:28:38 +0100 |
| commit | 64507fdbc29c3a622180378210ecea8659b14e40 (patch) | |
| tree | c42d87f221405f3ba9553984c39178caae3aac26 /net/netfilter | |
| parent | netfilter: ctnetlink: fix creation of conntrack with helpers (diff) | |
| download | linux-dev-64507fdbc29c3a622180378210ecea8659b14e40.tar.xz linux-dev-64507fdbc29c3a622180378210ecea8659b14e40.zip | |
netfilter: nf_queue: fix NF_STOLEN skb leak
commit 3bc38712e3a6e059 (handle NF_STOP and unknown verdicts in
nf_reinject) was a partial fix to packet leaks.
If user asks NF_STOLEN status, we must free the skb as well.
Reported-by: Afi Gjermund <afigjermund@gmail.com>
Signed-off-by: Eric DUmazet <eric.dumazet@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'net/netfilter')
| -rw-r--r-- | net/netfilter/nf_queue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c index 3a6fd77f7761..ba095fd014e5 100644 --- a/net/netfilter/nf_queue.c +++ b/net/netfilter/nf_queue.c @@ -265,7 +265,6 @@ void nf_reinject(struct nf_queue_entry *entry, unsigned int verdict) local_bh_disable(); entry->okfn(skb); local_bh_enable(); - case NF_STOLEN: break; case NF_QUEUE: if (!__nf_queue(skb, elem, entry->pf, entry->hook, @@ -273,6 +272,7 @@ void nf_reinject(struct nf_queue_entry *entry, unsigned int verdict) verdict >> NF_VERDICT_BITS)) goto next_hook; break; + case NF_STOLEN: default: kfree_skb(skb); } |