diff options
| author |   Bill Wendling <isanbard@gmail.com> | 2022-06-09 22:16:31 +0000 |
|---|---|---|
| committer |   Pablo Neira Ayuso <pablo@netfilter.org> | 2022-07-11 16:25:14 +0200 |
| commit | b8acd43148c067376f76faed9be138aa0e25414c (patch) | |
| tree | b79fafe1c9e7daa25ab0d12e1a1cbcafc40b1692 /net/netfilter | |
| parent | netfilter: conntrack: use fallthrough to cleanup (diff) | |
| download | linux-dev-b8acd43148c067376f76faed9be138aa0e25414c.tar.xz linux-dev-b8acd43148c067376f76faed9be138aa0e25414c.zip | |
netfilter: conntrack: use correct format characters
When compiling with -Wformat, clang emits the following warnings:
net/netfilter/nf_conntrack_helper.c:168:18: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
request_module(mod_name);
^~~~~~~~
Use a string literal for the format string.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <isanbard@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter')
| -rw-r--r-- | net/netfilter/nf_conntrack_helper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c index c12a87ebc3ee..1e0424d37abc 100644 --- a/net/netfilter/nf_conntrack_helper.c +++ b/net/netfilter/nf_conntrack_helper.c @@ -165,7 +165,7 @@ nf_nat_helper_try_module_get(const char *name, u16 l3num, u8 protonum) if (!nat) { snprintf(mod_name, sizeof(mod_name), "%s", h->nat_mod_name); rcu_read_unlock(); - request_module(mod_name); + request_module("%s", mod_name); rcu_read_lock(); nat = nf_conntrack_nat_helper_find(mod_name); |